workaround(java-21-openjdk-portable): pull spec from earlier snapshot…#16127
Open
binujp wants to merge 2 commits intotomls/base/mainfrom
Open
workaround(java-21-openjdk-portable): pull spec from earlier snapshot…#16127binujp wants to merge 2 commits intotomls/base/mainfrom
binujp wants to merge 2 commits intotomls/base/mainfrom
Conversation
… to satisfy version dep We build java-21 with portable sources 21.0.8.0.9. The head version of fed43 delivers 21.0.10.0.7. This will cause stage2 builds to fail. As a workaround pull from an older snapshot from before version was upgraded. By default a bootstrap build of jdk is done to make sure no other version of jdk is used accidentally. Since our stage2 is isolated and we are using the current version of jdk, ie. the one we built in stage1, to build portable sources, we disable bootstrap build.
binujp
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
ddstreetmicrosoft
requested changes
Mar 11, 2026
| @@ -0,0 +1,13 @@ | |||
| [components.java-21-openjdk-portable] | |||
Contributor
There was a problem hiding this comment.
I think you're including an emacs backup file here, this should be removed from the pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to satisfy version dep
We build java-21 with portable sources 21.0.8.0.9. The head version of fed43 delivers 21.0.10.0.7. This will cause stage2 builds to fail. As a workaround pull from an older snapshot from before version was upgraded.
By default a bootstrap build of jdk is done to make sure no other version of jdk is used accidentally. Since our stage2 is isolated and we are using the current version of jdk, ie. the one we built in stage1, to build portable sources, we disable bootstrap build.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology